search

umami-hep / umami-preprocessing

UPP: Umami PreProcessing
1 stars 35 forks source link

Adding Import fixes and Docstring #35

Closed afroch closed 1 year ago

afroch commented 1 year ago

This MR further improves the import behaviour and adds some docstrings

codecov[bot] commented 1 year ago

Codecov Report

Merging #35 (97241ab) into main (b08077f) will increase coverage by 0.18%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
+ Coverage   93.31%   93.49%   +0.18%     
==========================================
  Files          15       15              
  Lines         942      938       -4     
==========================================
- Hits          879      877       -2     
+ Misses         63       61       -2
Files Coverage Δ
upp/__init__.py 100.00% <100.00%> (ø)
upp/main.py 82.89% <100.00%> (+0.22%) :arrow_up:
upp/stages/hist.py 94.33% <100.00%> (ø)
upp/stages/plot.py 98.30% <100.00%> (+2.99%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

samvanstroud commented 1 year ago

Thanks @afroch, this is a very welcome addition. Can you fix the CI?

afroch commented 1 year ago

Thanks @afroch, this is a very welcome addition. Can you fix the CI?

Currently on it. Wrong precommit was installed. Currently fixing it

afroch commented 1 year ago

@samvanstroud the issue is fixed now. I also updated the version to have this version available in PyPi. I will create a tag/release once the PR is merged.