umami-hep / umami-preprocessing

UPP: Umami PreProcessing
1 stars 35 forks source link

Updated config file for Run 3 Kfold training #43

Closed nikitapond closed 1 year ago

nikitapond commented 1 year ago

Modifies the default config to create final kfold training sample for run 3 trainings.

codecov[bot] commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (9cf310e) 93.57% compared to head (a87a504) 93.57%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #43 +/- ## ======================================= Coverage 93.57% 93.57% ======================================= Files 15 15 Lines 950 950 ======================================= Hits 889 889 Misses 61 61 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

nikitapond commented 1 year ago

Confirmed that this config runs fine, we end up with 260m jets (same as previous set of kfold trainings) so no loss of stats.

samvanstroud commented 1 year ago

Confirmed that this config runs fine, we end up with 260m jets (same as previous set of kfold trainings) so no loss of stats.

Great thanks! When the linting is fixed I'm happy to merge

samvanstroud commented 1 year ago

I think maybe https://github.com/umami-hep/puma/pull/204#issuecomment-1822610369 was posted in the wrong place.

Maybe you can just add the different folds as comments?

nikitapond commented 1 year ago

I think maybe umami-hep/puma#204 (comment) was posted in the wrong place.

Maybe you can just add the different folds as comments?

Whoops my bad, too many tabs open! Yeah good idea I'll add them as comments

samvanstroud commented 1 year ago

Thanks @nikitapond ! Feel free to merge when you are ready

nikitapond commented 1 year ago

Thanks @nikitapond ! Feel free to merge when you are ready

I don't think I have write access, so doesn't look like I can merge.

samvanstroud commented 1 year ago

Thanks @nikitapond ! Feel free to merge when you are ready

I don't think I have write access, so doesn't look like I can merge.

Should be fixed now :)