Closed nikitapond closed 1 year ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
9cf310e
) 93.57% compared to head (a87a504
) 93.57%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Confirmed that this config runs fine, we end up with 260m jets (same as previous set of kfold trainings) so no loss of stats.
Confirmed that this config runs fine, we end up with 260m jets (same as previous set of kfold trainings) so no loss of stats.
Great thanks! When the linting is fixed I'm happy to merge
I think maybe https://github.com/umami-hep/puma/pull/204#issuecomment-1822610369 was posted in the wrong place.
Maybe you can just add the different folds as comments?
I think maybe umami-hep/puma#204 (comment) was posted in the wrong place.
Maybe you can just add the different folds as comments?
Whoops my bad, too many tabs open! Yeah good idea I'll add them as comments
Thanks @nikitapond ! Feel free to merge when you are ready
Thanks @nikitapond ! Feel free to merge when you are ready
I don't think I have write access, so doesn't look like I can merge.
Thanks @nikitapond ! Feel free to merge when you are ready
I don't think I have write access, so doesn't look like I can merge.
Should be fixed now :)
Modifies the default config to create final kfold training sample for run 3 trainings.