search

umami-hep / umami-preprocessing

UPP: Umami PreProcessing
1 stars 34 forks source link

Use global cuts to determine val and test num jets in Components class #50

Closed zcapjdb closed 9 months ago

zcapjdb commented 9 months ago

I noticed in the Components class it sets the num_jets for the validation and test splits equal to 10% of the training, see here

I don't think this should be hard coded as we define the cuts for the train, val and test split in the global_cuts.l

samvanstroud commented 9 months ago

It's not hard coded. If the key on those lines is defined it will use the value from the config. Otherwise by default 10% of the num training jets are used

zcapjdb commented 9 months ago

I did misread this yeah... oops my bad