search

umami-hep / umami-preprocessing

UPP: Umami PreProcessing
1 stars 35 forks source link

Flavour ratio differences tolerances are very small #59

Open Leonardo-Splendori opened 9 months ago

Leonardo-Splendori commented 9 months ago

Currently UPP requires flavour ratios to be close enough to eachother by using a numpy method with its default tolerances. https://github.com/umami-hep/umami-preprocessing/blob/main/upp/classes/components.py#L155

These default tolerances are very small, checking the documentation for numpy reveals they are 1e-5 and 1e-8 for relative and absolute tolerance respectively. It would be useful to offer a way to configure these, either by command line argument or in the config.

samvanstroud commented 9 months ago

I'd probably prefer to find a more suitable default choice than make this configurable. What tolerances work for you?