umami-hep / umami-preprocessing

UPP: Umami PreProcessing
1 stars 35 forks source link

define python version for new install #67

Closed nikitapond closed 2 months ago

nikitapond commented 2 months ago

When installing from fresh based on instructions in docs, I had errors (specifically, matching scipy version not found). By instead installing python 3.11 everything works (default seems to be 3.12)

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.19%. Comparing base (f7ef69c) to head (4c72695). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #67 +/- ## ======================================= Coverage 94.19% 94.19% ======================================= Files 15 15 Lines 964 964 ======================================= Hits 908 908 Misses 56 56 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

samvanstroud commented 2 months ago

Nice! we should probably think about upgrade the minimum required python in the pyproject.toml aslo, 3.8 is pretty old now

nikitapond commented 2 months ago

Nice! we should probably think about upgrade the minimum required python in the pyproject.toml aslo, 3.8 is pretty old now

Yes very true, I think 3.8 is soon to be unsupported