search

umami-software / umami

Umami is a simple, fast, privacy-focused alternative to Google Analytics.
https://umami.is
MIT License
21.95k stars 4.08k forks source link

Using detect-browser package that is no longer updated. #2874

Open psh4607 opened 1 month ago

psh4607 commented 1 month ago

Describe the Bug

detect-browser

It's been 3 years since the detect-browser package was updated. And there is no update to date. And many browsers and TV OSes have appeared. It needs to be reviewed for use in Umami.

Database

PostgreSQL

Relevant log output

No response

Which Umami version are you using? (if relevant)

latest

Which browser are you using? (if relevant)

arc, chrome, safari

How are you deploying your application? (if relevant)

docker

psh4607 commented 1 month ago

So I looked for a replacement package, and I found this: ua-parser-js

It seems to have a much wider range of device vendors and constantly updates many browsers. By the way, I am not the developer of this package.

psh4607 commented 1 month ago

Additionally, it seems like a good idea to stack UA in a session table in the DB so that customers can analyze it.

If the Umami team wants, I would like to upload a PR that modifies the prisma model and create session function.

Are there any restrictions or rules for uploading a PR?