umami-software / umami

Umami is a simple, fast, privacy-focused alternative to Google Analytics.
https://umami.is
MIT License
22.18k stars 4.14k forks source link

A bug in event when show Properties #2928

Open cottage opened 1 month ago

cottage commented 1 month ago

Describe the Bug

when two or more Properties of different events use the same name, only one property's data can be displayed. Clicking on another property with the same name does not have any effect.

1

Database

PostgreSQL

Relevant log output

No response

Which Umami version are you using? (if relevant)

v2.13.2

Which browser are you using? (if relevant)

chrome

How are you deploying your application? (if relevant)

manual install

pmauldin commented 3 weeks ago

Running into the same problem. From a quick investigation, it seems to be because the query is being cached by a websiteId|propertyName pair value, but does not include the eventName in the cache key:

https://github.com/umami-software/umami/blob/e881735a23df1db3318cbd2a97291e7e17193c76/src/components/hooks/queries/useEventDataValues.ts#L15

zandaqo commented 1 day ago

Same problem here. Is there a planned version for this fix? Kinda trivial thing but breaks the UX quite badly.