umang-p / brainlets

A website for tools/utilities related to the Girls' Frontline mobile game. http://brainlets.moe
http://brainlets.moe
GNU General Public License v3.0
6 stars 12 forks source link

K11 damage calculation does not appear to work correctly for bosses #22

Closed AristocratMC closed 5 years ago

AristocratMC commented 5 years ago

Reproduction steps:

Expected result:

Actual result:

Analysis: This is the result of the following factors:

  1. Stacking nades dealing double damage instead of 6x (4x+2x) damage.
  2. Stacking nades applying the damage amplification to all five nades, instead of only the four nades after the initial hit

Pull request #21 fixes this issue for now, but wondering if skill control would be a better approach, or if it's even worth trying to improve this over just letting the sim core routine rewrite take care of this and keep the current behavior of default to all overlap for bosses and no overlap for mobs in the meantime.

umang-p commented 5 years ago

I had considered adding a skill control for her to let users specify exactly how many grenades they would like to see overlap, but defaulting to all overlap for bosses and none for mobs is more consistent with the behavior of other dolls with similar "either way kinda works" skills. So, I'll keep PR #21 as the fix for this for now.

Thanks for the fix.