search

umanwizard / libeot

Library for parsing Embedded OpenType files (Microsoft embedded font "standard"), and converting them to other formats
Other
14 stars 6 forks source link

CVT table parser ignores table offset #1

Closed yarmola closed 10 years ago

yarmola commented 10 years ago

when you read 'cvt ' table calling to unpackCVT, you better seek to tbl->offset first. or it is not working, continuing parsing where previous table ends.

in the lucky case when these 2 tables are one after another (in table dir), it may work fine.

umanwizard commented 10 years ago

Thanks Yuri

Do you have an example EOT where this breaks?

yarmola commented 10 years ago

Sure.

This one should do it.

Basically you may try it with any file where “physical” ordering of the tables don’t match their ordering in the table directory - if one of such tables precedes “cvt"

(please, take the font file as “testing only” thing).

I can send you our TransType as well, just let me know if you want Win or Mac version.

On 01 Dec 2013, at 00:09, umanwizard notifications@github.com wrote:

Thanks Yuri

Do you have an example EOT where this breaks?

— Reply to this email directly or view it on GitHub.

umanwizard commented 10 years ago

I can't find the font. I'm not sure if github allows attachments in issues.

Anyway, I believe I have fixed the bug, but would like to try it on an example to verify :). Can you email me a copy at brennan@umanwizard.com or brennanv@email.arizona.edu ?

Also, a copy of TransType would be good too. I use Mac and FreeBSD primarily, so a mac version would do if you don't have a FreeBSD one.

Thanks Brennan

yarmola commented 10 years ago

Hi Brennan,

This is the font: https://www.dropbox.com/s/orvqviebwu1klqx/SourceSansPro-Light5.eot

This is the app: https://www.dropbox.com/s/oq1h24oanojx90f/TransType4-5029-signed.zip

It will fork fine for some time, let me know if you need to use it after trial expires so I prepare a key code for you.

Best regards, Yuri

On 01 Dec 2013, at 05:12, umanwizard notifications@github.com wrote:

I can't find the font. I'm not sure if github allows attachments in issues.

Anyway, I believe I have fixed the bug, but would like to try it on an example to verify :). Can you email me a copy at brennan@umanwizard.com or brennanv@email.arizona.edu ?

Also, a copy of TransType would be good too. I use Mac and FreeBSD primarily, so a mac version would do if you don't have a FreeBSD one.

Thanks Brennan

— Reply to this email directly or view it on GitHub.

umanwizard commented 10 years ago

Hi Yuri

I believe the issue is fixed in my latest commit.

Thanks for your help. I hope libeot continues to be useful to you. Let me know if you have any more issues.