umap-project / umap

uMap lets you create maps with OpenStreetMap layers in a minute and embed them in your site.
https://umap-project.org
Other
1.2k stars 227 forks source link

Feedback on new icon image feature #1417

Open virgile-dev opened 1 year ago

virgile-dev commented 1 year ago

Awesome work, the icon selection is great, categorization too and being, emojis and img urls work great too 👏 Here are a couple things I'd like to provide feedback on.

Icons background color Why are we displaying a grey background? I find that this way icons are less salient. Capture d’écran 2023-11-21 à 11 13 12

Here is a test with a white background. Any reason we don't go with that ? Capture d’écran 2023-11-21 à 11 22 16

Icon image size is a bit small On my laptop, Icons display in 1515px --> How about we make those bigger ? Emojis : 24,5524px Images : 24*24px

I tried a few bigger sizes for the Iconsand it was easier for me to read. Current default size 15*15px Capture d’écran 2023-11-21 à 11 31 47

Here is with 20*20px Capture d’écran 2023-11-21 à 11 32 07

Here is with 0*30px Capture d’écran 2023-11-21 à 11 32 17

yohanboniface commented 1 year ago

Thanks for the report!

Why are we displaying a grey background?

We don't know how other instances will use pictograms, so we need to keep a background that can allow any color (including white).

I tried a few bigger sizes for the Iconsand it was easier for me to read.

This depends on the icon itself, and the resolution of your screen. But I'll let @Aurelie-Jallut take the point :)

virgile-dev commented 1 year ago

Thanks for your answer !

We don't know how other instances will use pictograms, so we need to keep a background that can allow any color (including white).

Why don't make the background dynamic based on the color of the icon ? Leaning to white -> dark, leaning to black -> bright.

Another way would be to have a config option / env variable when installing umap.

yohanboniface commented 1 year ago

Why don't make the background dynamic based on the color of the icon ? Leaning to white -> dark, leaning to black -> bright.

When we'll have one million $ a year :p

Aurelie-Jallut commented 1 year ago

On the subject of the size of the picto on the left menu and on the map, have you tested on several screens / resolutions?

virgile-dev commented 1 year ago

On the subject of the size of the picto on the left menu and on the map, have you tested on several screens / resolutions?

Yup it's always 15*15px on my computer

yohanboniface commented 6 months ago

How are we on this, amigos ?