umap-project / umap

uMap lets you create maps with OpenStreetMap layers in a minute and embed them in your site.
https://umap-project.org
Other
1.16k stars 220 forks source link

"Merge lines" no longer working #2125

Closed Player701 closed 2 weeks ago

Player701 commented 2 weeks ago

Describe the bug Attempting to merge two lines results in an error.

To Reproduce Steps to reproduce the behavior:

  1. Go to https://umap.openstreetmap.fr/
  2. Create a new map
  3. Draw a line
  4. Draw another line, starting close to where the line drawn in p.3 ends
  5. Drag the line drawn in p.4 so that its starting point overlaps with the ending point of the line drawn in p.3
  6. Right-click on the line drawn in p.3, choose "Transfer shape to edited feature"
  7. Right-click on the overlapping points, choose "Merge lines"
  8. Observe error: "TypeError: this.getLatLngs is not a function"

Expected behavior The lines get merged.

Screenshots N/A

Desktop (please complete the following information):

Smartphone (please complete the following information): N/A

Additional context Used to work just a few days ago.

yohanboniface commented 2 weeks ago

Thanks again! I'm having a look :)

Draw another line, starting close to where the line drawn in p.3 ends Drag the line drawn in p.4 so that its starting point overlaps with the ending point of the line drawn in p.3 Right-click on the line drawn in p.3, choose "Transfer shape to edited feature"

For the same result, you could directly draw a multi line using this icon:

image