search

umap-project / umap

uMap lets you create maps with OpenStreetMap layers in a minute and embed them in your site.
https://umap-project.org
Other
1.19k stars 227 forks source link

When menu items extend beyond bottom of screen #558

Open jidanni opened 6 years ago

jidanni commented 6 years ago

Edit a point. In the right panel, last below Coordinates, is an "Advanced actions" button. Pressing it does nothing. If it is a empty sub-menu then don't show it, else the user will think it is broken.

simon1tan commented 6 years ago

When I click it, I get a "Delete" button in the sub-menu.

eehpcm commented 6 years ago

@jidanni

It's not broken, it's merely shy and retiring. It doesn't want to show itself. :)

If your browser window is not large enough (for some vague value of "large") then clicking on "Advanced actions" does expand a sub-menu, just like all the other options, but the sub-menu remains coyly hidden below the visible extent in the browser window. Scroll down, and there it is.

As UIs go, it could be improved. But it's probably not a high priority given some of the other issues. It's sub-optimal, but it works if you know what to do. Some of the other issues are about things that don't work at all.

jidanni commented 6 years ago

OK I found the scroll bar. OK I will be thrifty and change this into another issue...

Also if a menu extends beyond the bottom of the screen, 0 it should change into two columns or something. Note there is no way to scroll it down.

eehpcm commented 6 years ago

@jidanni

You keep your browser window even smaller than I do. So naturally, I changed the size of mine to test it. Yeah, it affects the left-hand and right-hand button collections. I suspect it's not too hard to fix that one (although you need to account for how many buttons are displayed in the left-hand collection, since that is definable by the map creator). OTOH, I haven't looked at the code so it could be very difficult. But I'm guessing it's using a library that can be asked to cope with things like that automatically (by passing the "Don't screw up" flag or some such).

The problem you originally reported might be harder to handle without a redesign of the UI.

Somewhere in the 200+ issues, the lead developer mentioned that he's not very active on the project any more. So my best advice goes like the old joke about the patient who says to his doctor "It hurts when I do this." and the doctor replies "Don't do that." The best interim solution I can offer is to increase the size of your browser window (which may not be possible).

jidanni commented 6 years ago

(And yes, I'm already at fullscreen so cannot get a larger window.)