search

umartechboy / 2-Boots-Mega-2560

4 stars 0 forks source link

Coding Errors #2

Open DriekdeGadgetfreak opened 5 years ago

DriekdeGadgetfreak commented 5 years ago

Excellent job! I really appreciate it. I found 2 errors.

small error:

instead of: for (int kk = 0; kk < 9; kk++) eeprom_write_byte((void *)E2END - i, 0xFF);

use:

            for (int kk = 0; kk < 9; kk++)
                eeprom_write_byte((void *)EE_NAMEE - kk, 0xFF);

and a big one:

Last page of hex file is not written. Add:

/* something not written? */
if (out - pagebuffer) {
    // write page
    #ifdef SHOW_PROGRGESS_ON_SERIAL
    PrintString("PageWrite: ");
    PrintHexByte((uint32_t)address >> 16);
    PrintHexByte((uint32_t)address >> 8);
    PrintHexByte((uint32_t)address );
    PrintString("\r\n");
    #endif
    write_flash_page();
}

to the end of read_hex_file()