umasteeringgroup / UMA

Unity Multipurpose Avatar
MIT License
739 stars 168 forks source link

Errors installing the UMA-2.13rc8 package into a new 2022.3.15f1 project #447

Open prof-jerz opened 3 months ago

prof-jerz commented 3 months ago

I am only a beginner and am grateful to see that work continues on this great project.

Describe the bug A clear and concise description of what the bug is.

Two compiling errors after importing the rc8 package into a blank project.

Assets/UMA/Core/StandardAssets/UMA/Scripts/SlotDataAsset.cs(1,12): error CS0234: The type or namespace name 'Cecil' does not exist in the namespace 'Mono' (are you missing an assembly reference?)

hader error in 'Custom/Subsurface Scattering': redefinition of 'RoughnessToPerceptualRoughness' at Assets/UMA/Content/SkinShaders/Shader/SSS_Utils.cginc(5) (on metal)

SHADOWS_SHADOWMASK UNITY_ASTC_NORMALMAP_ENCODING UNITY_HALF_PRECISION_FRAGMENT_SHADER_REGISTERS UNITY_HARDWARE_TIER1 UNITY_HARDWARE_TIER2 UNITY_HARDWARE_TIER3 UNITY_LIGHTMAP_DLDR_ENCODING UNITY_LIGHTMAP_RGBM_ENCODING UNITY_METAL_SHADOWS_USE_POINT_FILTERING UNITY_NO_DXT5nm UNITY_NO_FULL_STANDARD_SHADER UNITY_NO_SCREENSPACE_SHADOWS UNITY_PBS_USE_BRDF2 UNITY_PBS_USE_BRDF3 UNITY_PRETRANSFORM_TO_DISPLAY_ORIENTATION UNITY_UNIFIED_SHADER_PRECISION_MODEL UNITY_VIRTUAL_TEXTURING VERTEXLIGHT_ON _GLOSSYREFLECTIONS_OFF _SPECULARHIGHLIGHTS_OFF

Environment (please complete the following information):

To Reproduce Steps to reproduce the behavior:

  1. Downloaded uma213RC8.unitypackage
  2. In Unity Hub, created new 3D project with built-in render pipeline (2022.3.15f) (blank project compiled as expected)
  3. Project -> Import Package -> uma213RC8.unitypackage (two compiling errors as noted above)

Expected behavior Expected project to compile so that I could start testing UMA 2.13rc8.

Screenshots If applicable, add screenshots to help explain your problem.

Additional context I am beginner and have no idea whether installing the .unitypackage is the right way to test out this release candidate. I could not figure out how to add 2.13rc8 through the package manager, or how to add it from disk. Perhaps I'm missing something obvious?

Jaimi commented 3 months ago

Importing the package was the correct thing to do. Once the RC is over, and it's uploaded to the asset store, you would then be able to load it from Package Manager. I'm assuming you are on a mac? What version of OS?

To get it going, you can remove the using for mono.cecil. This should exist, but is not needed anyway (Visual Studio will insert phantom usings sometimes). I've done this in my current code base, and will have the fix in the next update.

The shader error is a concern because that should also just work. It seems like there is probably some #ifdef goofiness going on that isn't taking into account Metal. That specific shader is only used in BiRP though. There is a different skin shader for URP/HDRP. I will need to get my Mac running and test this one.

prof-jerz commented 3 months ago

Yes, MacBook Air, Chip Apple M2, Sonoma 14.5.

Thank you for your response. I'll be happy to test the next update on my Mac.