umautobots / vod-converter

Convert between visual object detection datasets
MIT License
307 stars 93 forks source link

KITTI annotations are corrupted after converting to VOC pascal format #13

Closed yossibiton closed 6 years ago

yossibiton commented 6 years ago

The annotations files has some mistakes after the conversion.

For example : https://github.com/umautobots/vod-converter/blob/master/vod_converter/kitti.py#L100 in this line the bounding box right border is limited to 1023, although kitti images size is much larger than 1023.

krosaen commented 6 years ago

thanks for pointing this out, I'm not sure why this mistaken assumption was baked into the script. will fix asap, happy to accept a PR if you are eager.

yossibiton commented 6 years ago

Sorry but i don't have PR for that. I also found other bugs with the occlusion field values which aren't converted correctly.

Eventually I have decided to use the original annotations files of KITTI and skip the conversion.

On Thu, Nov 9, 2017 at 11:18 PM Karl Rosaen notifications@github.com wrote:

thanks for pointing this out, I'm not sure why this mistaken assumption was baked into the script. will fix asap, happy to accept a PR if you are eager.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/umautobots/vod-converter/issues/13#issuecomment-343294683, or mute the thread https://github.com/notifications/unsubscribe-auth/AGN1AJyw0-Tso2DxxTAHS_I39nGsQfLGks5s02wtgaJpZM4QYFUN .

krosaen commented 6 years ago

Yeah, VOC doesn't have a notion of occlusion, so it is currently dropped (e.g any model that was originally training on pascal VOC doesn't expect occlusion fields), but I can imagine adding a custom field. Thanks again for reporting the issue.

yossibiton commented 6 years ago

The converted files in VOC format does have occlusion field but the values there are wrong

On Fri, Nov 10, 2017, 15:43 Karl Rosaen notifications@github.com wrote:

Yeah, VOC doesn't have a notion of occlusion, so it is currently dropped (e.g any model that was originally training on pascal VOC doesn't expect occlusion fields), but I can imagine adding a custom field. Thanks again for reporting the issue.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/umautobots/vod-converter/issues/13#issuecomment-343476545, or mute the thread https://github.com/notifications/unsubscribe-auth/AGN1AGf55e2Xfi8Z2hA6BV325EFeLtWNks5s1FL1gaJpZM4QYFUN .

krosaen commented 6 years ago

@yossibiton just fixed the issue, and when looking at the dataset in our viewer, I can see that things look good towards the right side of the images. It's possible that the wrong values of the don't care regions were also due to the same issue; see in this example the don't care region is now in place across the cars in the upper right

kitti-dontcare

krosaen commented 6 years ago

@yossibiton wait sorry you were talking about occlusion. I'll take a look at don't care values. On initial glance it looks like they aren't really being read in at all for kitti ingenstion.

krosaen commented 6 years ago

After looking more closely / refreshing my memory, the converter currently doesn't have a notion of occlusion in its intermediate format; when egesting KITTI it will output a value for that field but it is not meaningful. The converter currently focuses on getting labeled bounding boxes in and out of various formats, I'll consider having a notion of occlusion an enhancement todo going forward.

krosaen commented 6 years ago

see #14 for more notes on occlusion field