Closed palkx closed 1 month ago
hi, @palkx Thank you for contributing! Looks good to me. Please just remove 2 unnecessary tabs (line 70 and 75) and new empty line (line 83) from the 1st commit and I will merge it.
Sorry about that. Looks like my formatting tool wasn't enabled. I've reenabled it and fixed the formatting issues you mentioned, please recheck if everything is good now.
Fixes #3
Hello @umax
As stated in issue #3 sonarqube is advising migrating to a new generic-issue-format
So, I've actually made the necessary changes to use a new format, updated the tests and validated it in a real environment.
Please review it and merge if there are no objections.
Thanks a lot.