umayr / theme-sushi

Sushi theme for Fishshell.
MIT License
23 stars 20 forks source link

Fix SSH Client test #19

Closed alyyousuf7 closed 4 years ago

alyyousuf7 commented 4 years ago

The right prompt is displaying user:host even on non-ssh'ed machines.

The issue is, set -q tests if the variable was ever set.

I have replaced it with test -n to test if the variable is empty.

This should fix the issue.

mbrgm commented 4 years ago

@umayr Would you mind merging this? I can confirm the problem @alyyousuf7 described and this PR fixes the issue for me.

haroonKhan-10p commented 4 years ago

faced the same issue. updated it manually. Because it is annoying to see the user:host. Would be helpful to get this merged.