our-svg default cache can't be overridden

umbraco-community / Our-Umbraco-TagHelpers

A community project of C# ASP.NET TagHelpers for the Open Source CMS Umbraco

MIT License

31 stars 26 forks source link

our-svg default cache can't be overridden #57

Open drpeck opened 1 year ago

drpeck commented 1 year ago

If you set the SVG cache to be on in appsettings.config, and then wish to disable it on a specific tag instance then it is not possible.

Ideally InlineSvgTagHelper.Cache (https://github.com/umbraco-community/Our-Umbraco-TagHelpers/blob/main/Our.Umbraco.TagHelpers/InlineSvgTagHelper.cs#L72) would be nullable, and it would respect a true/false value before considering the appsettings.config value.

warrenbuckley commented 1 year ago

Hiya @drpeck Would you be interested in doing the fix in a PR and perhaps update the unit test to ensure this scenario & the other issue with our-svg in #58 ?