Console errors after installing 1.0.0-beta2

[bjarnef]

After installing v1.0.0-beta2 in a Umbraco 7.4.3 installation I get the following:

Debug is set to false.

[abjerner]

@bjarnef Have you tried doing a hard refresh?

For v1.0.0-beta2 the controller is now called OpeningHours.Controllers.OpeningHoursController (Pascal casing rather than camel casing), so it should just be a matter of refreshing the view in your browser.

https://github.com/bomortensen/Our.Umbraco.OpeningHours/blob/master/src/Our.Umbraco.OpeningHours/App_Plugins/OpeningHours/views/Editors/OpeningHours.html#L1

[bjarnef]

@abjerner yes, hard refresh, recycle application pool, set debug to false.

but still having the issue. Also tried to increase client dependency version number.

This is installed via Umbraco package (.zip) - not NuGet.

~/OpeningHours/views/Editors/OpeningHours.html

~/OpeningHours/Controllers/OpeningHoursEditor.js

I also have this file... hmm, not sure - I think it was from the old version and a installed the new one (upgraded). ~/OpeningHours/js/openingHours.controllers.js

package.manifest

So it seems the Umbraco .zip file isn't up-to-date since the controller name in OpeningHours.html is OpeningHours.html ... but on Github it is PascalCase: https://github.com/bomortensen/Our.Umbraco.OpeningHours/blob/master/src/Our.Umbraco.OpeningHours/App_Plugins/OpeningHours/views/Editors/OpeningHours.html#L1

[abjerner]

@bjarnef Thanks for the update.

It seems that the Umbraco package contains both the old and new files for the cases the files were renamed to have another case. Filenames in a ZIP file are apparently case-sensitive, so OpeningHours.html is not the same as openingHours.html. Then things get interesting when extracting the ZIP on a Windows system.

All of this is most likely caused by an issue with by build job, so I need to look into that.

[bjarnef]

Yes, uninstalled the package completely and installed it again, which e.g. contains the old file ~/OpeningHours/js/openingHours.controllers.js although not included in package.manifest.

[abjerner]

Well ... vacation happened. And then coming back to work happened ... so I haven't really had time to work on this package for a while.

Anyways - I have now fixed the Grunt file so the Umbraco package is properly generated, and confirmed that this works in a fresh Umbraco 7.5.3 installation. Just to be sure - can you confirm this on your end as well?

[bjarnef]

Hi Anders

I have tested beta3 and it now works in Umbraco 7.4.3

A minor thing I noticed is that the delete button in "holiday opening hours" doesn't use a pointer cursor, because it doesn't have href attribute. You can add href and prevent-default attribute directive - or style a[ng-click]

[abjerner]

@bjarnef Thanks. I hadn't noticed the missing href attribute - it is now fixed ;)

Also, closing the issue since the Grunt thing is now fixed.