Added support for Azure Key Vault Storage in Umbraco 7

umbraco-community / UmbracoFileSystemProviders.Azure

:cloud: An Azure Blob Storage IFileSystem provider for Umbraco

96 stars 67 forks source link

Closed RachBreeze closed 3 years ago

RachBreeze commented 3 years ago

Hello,

This PR adds support for Azure Key Vault in Umbraco 7, it is based on #182

Jeavon commented 3 years ago

@RachBreeze Any idea what the conflicts are?

RachBreeze commented 3 years ago

Hi @Jeavon erm I think I'm merging to the wrong branch https://github.com/umbraco-community/UmbracoFileSystemProviders.Azure/pull/190/commits/dc725bebc0b0a097f92dfa7ec83826f51bb3e496 says into develop-umbraco-version-8. Not into v7. Let me see if I can fix this, if not I may need to make a new PR

RachBreeze commented 3 years ago

Hi @Jeavon I have made that change, I apologise for not checking the branch I was making the PR back into

RachBreeze commented 3 years ago

Hi @Jeavon Is everything ok with this? We have a client on Umbraco 7 who would like to use this functionality

Thank you

Rachel

Jeavon commented 3 years ago

@RachBreeze Looks good, just firing up the v1 pipelines, it's been a while!

Jeavon commented 3 years ago

If you want to test, it's available on MyGet, will release to NuGet next week

Install-Package UmbracoFileSystemProviders.Azure -Version 1.2.0-alpha-000443 -Source https://www.myget.org/F/umbraco-packages/api/v3/index.json

RachBreeze commented 3 years ago

Hi @Jeavon amazing thank you

Jeavon commented 3 years ago

Released in v1.2 - thanks again @RachBreeze