search

umbraco-community / umbraco-analytics

Google Analytics for the Umbraco CMS
40 stars 31 forks source link

Typo in itemTransactions #31

Closed bjarnef closed 9 years ago

bjarnef commented 9 years ago

It seems it wasn't merged correctly to master branch last time.

warrenbuckley commented 9 years ago

@bjarnef I thought I mentioned this to you but we intend to try and use a GitFlow approach to this repo so any new features are created with a feature branch.

Can you verify your change is in a different branch such as develop please?

The goal is to use AppVeyor to do automated umbraco & nuget package builds from every commit to the GitHub repo.

Every commit/merge into the master branch is a release and will push to NuGet from memory, but as we got stuck on an issue before I release, I've forgotten how this is setup.

Cheers, Warren :)

Jeavon commented 9 years ago

This PR should to be targeted to the develop branch, not master, then the build should pass.

bjarnef commented 9 years ago

@warrenbuckley okay, I didn't noticed there have been created a "develop" branch too.. I will change to develop-branch.

Jeavon commented 9 years ago

@warrenbuckley I would suggest you change the default branch to "develop" :)

warrenbuckley commented 9 years ago

@Jeavon how do i do that?

bjarnef commented 9 years ago

@warrenbuckley in the settings for the repository you can set the default branch.

capture