umbraco-community / umbraco-analytics

Google Analytics for the Umbraco CMS
40 stars 31 forks source link

Moving Tree nodes definitions to a new config file #46

Closed hfloyd closed 8 years ago

hfloyd commented 8 years ago

I was interested in adding my own custom analytics data (based on site-specific GA Events) to the Analytics section. Everything I needed to edit was within the "App_Plugins/Analytics" folder except the tree definitions. So I tweaked that bit of code to use a new "treenodes.config" file rather than having them hard-coded in the "AnalyticsTreeController.cs" file.

For people who are not interested in adding custom analytics data, nothing will change with the default install. For those who are interested in some customization, the config file makes it easy to add new tree items - or re-order tree items, etc.

warrenbuckley commented 8 years ago

Hey @hfloyd thanks for the contrib, just had a quick skim through and this all seems fine to me moving it out into a config file.

hfloyd commented 8 years ago

Thanks, @warrenbuckley!

Oh - I didn't look closely at your build & package scripts, so I'm not sure if something special needs to be added to make sure the "treenodes.config" file gets included in install packages?