Update Chart.js to latest version

umbraco-community / umbraco-analytics

Google Analytics for the Umbraco CMS

41 stars 31 forks source link

Update Chart.js to latest version #48

Open bjarnef opened 7 years ago

bjarnef commented 7 years ago

Can we update Chart.js to latest version 2.4.0? https://github.com/chartjs/Chart.js/releases

At the moment Analytics use version 1.0.1-beta.4 https://github.com/warrenbuckley/Analytics/blob/688a9756ef1c6eafa166dc07db81b9c60f156ae4/Analytics/App_Plugins/Analytics/lib/chartjs/Chart.js#L4

warrenbuckley commented 7 years ago

Any specific reason @bjarnef anything missing or needed or it fixes up? Either way feel free to do a PR mate :)

bjarnef commented 7 years ago

@warrenbuckley it has some cool new features like Mixed chart types, New chart axis types and animations when there is change in dataset. http://www.chartjs.org/

Furthermore the current version was a beta, so it seems there a lot of bugfixes, enhancements and new features 👍 https://github.com/chartjs/Chart.js/releases

bjarnef commented 7 years ago

I need to adjust it a bit more for version 2.4.0 @warrenbuckley maybe create a milestone for Analytics version 1.3.0?

warrenbuckley commented 7 years ago

OK well free to do a PR then please. I unfortunately don't have as much time as I once used to :(