search

umbraco-community / umbraco-analytics

Google Analytics for the Umbraco CMS
41 stars 31 forks source link

Issue #28 and #56 #60

Closed Emetico closed 5 years ago

Emetico commented 6 years ago

Added a fix to https://github.com/warrenbuckley/Analytics/issues/28 and https://github.com/warrenbuckley/Analytics/issues/56

  1. Changed $scope.$apply to $timout in Analytics.SettingsController to fix $digest already in progress error.

  2. Removed ~/App_Plugins/Analytics/lib/momentjs/moment.js from package.config.

  3. Added assetsService to dateRangePicker directive to load moment.js before executing daterangepicker.

warrenbuckley commented 5 years ago

Looks good to me - thanks @Emetico