search

umbraco-community / umbraco-analytics

Google Analytics for the Umbraco CMS
40 stars 31 forks source link

No charts when debug="false" in web.config/compilation #8

Closed vnbaaij closed 2 years ago

vnbaaij commented 9 years ago

Hi,

On our local 7.1.6 dev environment everything works like a charm with the latest Analtics package. On our staging environment we get a javascript error when in web.config in the compilation element the debug attribite is set tot false:

SyntaxError: Unexpected token = at Function (native) at e (http://stadgenoot-staging.azurewebsites.net/DependencyHandler.axd?s=L3VtYnJ…dlcGlja2VyL2RhdGVyYW5nZXBpY2tlci5qczs&t=Javascript&cdv=315663375:1275:4408) at s.template (http://stadgenoot-staging.azurewebsites.net/DependencyHandler.axd?s=L3VtYnJ…dlcGlja2VyL2RhdGVyYW5nZXBpY2tlci5qczs&t=Javascript&cdv=315663375:1275:4477) at e.Scale.e.Element.extend.buildYLabels (http://stadgenoot-staging.azurewebsites.net/DependencyHandler.axd?s=L3VtYnJ…lcGlja2VyL2RhdGVyYW5nZXBpY2tlci5qczs&t=Javascript&cdv=315663375:1275:18637) at e.Scale.e.Element.extend.fit (http://stadgenoot-staging.azurewebsites.net/DependencyHandler.axd?s=L3VtYnJ…lcGlja2VyL2RhdGVyYW5nZXBpY2tlci5qczs&t=Javascript&cdv=315663375:1275:19203) at e.Scale.e.Element.extend.initialize (http://stadgenoot-staging.azurewebsites.net/DependencyHandler.axd?s=L3VtYnJ…lcGlja2VyL2RhdGVyYW5nZXBpY2tlci5qczs&t=Javascript&cdv=315663375:1275:18522) at e.Element (http://stadgenoot-staging.azurewebsites.net/DependencyHandler.axd?s=L3VtYnJ…lcGlja2VyL2RhdGVyYW5nZXBpY2tlci5qczs&t=Javascript&cdv=315663375:1275:13464) at new e (http://stadgenoot-staging.azurewebsites.net/DependencyHandler.axd?s=L3VtYnJ…dlcGlja2VyL2RhdGVyYW5nZXBpY2tlci5qczs&t=Javascript&cdv=315663375:1275:2190) at Object.i.Type.extend.buildScale (http://stadgenoot-staging.azurewebsites.net/DependencyHandler.axd?s=L3VtYnJ…lcGlja2VyL2RhdGVyYW5nZXBpY2tlci5qczs&t=Javascript&cdv=315663375:1275:38149) at Object. (http://stadgenoot-staging.azurewebsites.net/DependencyHandler.axd?s=L3VtYnJ…lcGlja2VyL2RhdGVyYW5nZXBpY2tlci5qczs&t=Javascript&cdv=315663375:1275:36164)DependencyHandler.axd?s=L3VtYnJhY28vbGliL2pxdWVyeS9qcXVlcnktMi4wLjMubWluLmpzOy91bWJyYWNvL2xpYi9hbmd…:12 (anonymous function)DependencyHandler.axd?s=L3VtYnJhY28vbGliL2pxdWVyeS9qcXVlcnktMi4wLjMubWluLmpzOy91bWJyYWNvL2xpYi9hbmd…:11 (anonymous function)DependencyHandler.axd?s=L3VtYnJhY28vbGliL2pxdWVyeS9qcXVlcnktMi4wLjMubWluLmpzOy91bWJyYWNvL2xpYi9hbmd…:14 iDependencyHandler.axd?s=L3VtYnJhY28vbGliL2pxdWVyeS9qcXVlcnktMi4wLjMubWluLmpzOy91bWJyYWNvL2xpYi9hbmd…:14 iDependencyHandler.axd?s=L3VtYnJhY28vbGliL2pxdWVyeS9qcXVlcnktMi4wLjMubWluLmpzOy91bWJyYWNvL2xpYi9hbmd…:14 iDependencyHandler.axd?s=L3VtYnJhY28vbGliL2pxdWVyeS9qcXVlcnktMi4wLjMubWluLmpzOy91bWJyYWNvL2xpYi9hbmd…:14 iDependencyHandler.axd?s=L3VtYnJhY28vbGliL2pxdWVyeS9qcXVlcnktMi4wLjMubWluLmpzOy91bWJyYWNvL2xpYi9hbmd…:14 (anonymous function)DependencyHandler.axd?s=L3VtYnJhY28vbGliL2pxdWVyeS9qcXVlcnktMi4wLjMubWluLmpzOy91bWJyYWNvL2xpYi9hbmd…:14 e.$evalDependencyHandler.axd?s=L3VtYnJhY28vbGliL2pxdWVyeS9qcXVlcnktMi4wLjMubWluLmpzOy91bWJyYWNvL2xpYi9hbmd…:14 e.$digestDependencyHandler.axd?s=L3VtYnJhY28vbGliL2pxdWVyeS9qcXVlcnktMi4wLjMubWluLmpzOy91bWJyYWNvL2xpYi9hbmd…:14 e.$applyDependencyHandler.axd?s=L3VtYnJhY28vbGliL2pxdWVyeS9qcXVlcnktMi4wLjMubWluLmpzOy91bWJyYWNvL2xpYi9hbmd…:14 jDependencyHandler.axd?s=L3VtYnJhY28vbGliL2pxdWVyeS9qcXVlcnktMi4wLjMubWluLmpzOy91bWJyYWNvL2xpYi9hbmd…:15 rDependencyHandler.axd?s=L3VtYnJhY28vbGliL2pxdWVyeS9qcXVlcnktMi4wLjMubWluLmpzOy91bWJyYWNvL2xpYi9hbmd…:16 v.onreadystatechange

warrenbuckley commented 9 years ago

Hi @vnbaaij Yes the 1.1.0 release I done yesterday with @bjarnef was a little rushed on my part and we are aware that this release has bugs in it.

Sorry for any inconvenience caused.

Cheers, Warren :)

warrenbuckley commented 9 years ago

Hi @vnbaaij I believe there is an issue with some new JS we have written or the update to the ChartJS library is not agreeing with the Client Dependancy Framework in Umbraco.

I need to investigate how to resolve this or a way to exclude certain files from CDF.

If this is a pressing issue, a very temporary fix would be to set debug to true in the web.config

vnbaaij commented 9 years ago

For now we've done that exactly. We'll stick with the previous version on the productionserver until it's resolved

warrenbuckley commented 9 years ago

@vnbaaij this will be resolved in the next minor release coming in the next few days and was to do with some obscure error with using the chartjs minified library with CDF. This has been looked into and resolved. Will leave this issue open until we release the next minor version with the fix.

warrenbuckley commented 9 years ago

@vnbaaij Please can you test & verify this is fixed in version 1.2.0 so I can close this issue off.