umbraco-community / umbraco-analytics

Google Analytics for the Umbraco CMS
40 stars 31 forks source link

Change of date range not completely update chart #9

Closed bjarnef closed 9 years ago

bjarnef commented 9 years ago

When you change the date range, it does update the chart. However with the new interactive features in the new version of Chart.js, it seems to keep the old version of the chart when hovering the chart.

I think we somehow need to update/refresh/redraw the chart after the date range has been changed.

bjarnef commented 9 years ago

I found a way to redraw/clear the existing canvas graph before drawing the new one in the watch for datechange. At the same time testing with a newer version of ChartJS and generate the legends with "legendTemplate", where it's added based on the datasets.

warrenbuckley commented 9 years ago

Is this resolved now @bjarnef due to your commit for this?

bjarnef commented 9 years ago

Yes it should be.. It worked when I tested It at that time :)

warrenbuckley commented 9 years ago

Will close this then @bjarnef