search

umbraco-community / umbraco-graphql

An implementation of GraphQL for Umbraco 8 using GraphQL for .NET.
MIT License
64 stars 32 forks source link

Fixed build issues Umbraco8 #51

Closed rasmuseeg closed 4 years ago

rasmuseeg commented 4 years ago

When first starting the project i had several build issues. These are now fixed by using newer version of referenced nuget packages.

rasmusjp commented 4 years ago

Hi @rasmuseeg

Thanks for the PR. What build issues did you have? I can see that you've upgraded the Umbraco packages, if we can avoid that it would be awesome since I don't want to force people to upgrade to a later version if it's not needed.

rasmuseeg commented 4 years ago

I @rasmusjp i just cloned the umbracov8 branch, started the .sln with VS Studio 2019, and tried to run the project. These are the ones that was having conflicts, and the whole reason i had to upgrade the others.

  <package id="System.Diagnostics.Debug" version="4.3.0" targetFramework="net472" />      <package id="System.Diagnostics.Debug" version="4.3.0" targetFramework="net472" />
  <package id="System.Diagnostics.DiagnosticSource" version="4.4.1" targetFramework="net472" />   <package id="System.Diagnostics.DiagnosticSource" version="4.6.0" targetFramework="net472" />
  <package id="System.Diagnostics.FileVersionInfo" version="4.3.0" targetFramework="net472" />    <package id="System.Diagnostics.FileVersionInfo" version="4.3.0" targetFramework="net472" />
  <package id="System.Diagnostics.StackTrace" version="4.3.0" targetFramework="net472" />     <package id="System.Diagnostics.StackTrace" version="4.3.0" targetFramework="net472" />
  <package id="System.Diagnostics.Tools" version="4.3.0" targetFramework="net472" />