search

umbraco / OurUmbraco

MIT License
96 stars 171 forks source link

Avatars are squeezed on community site #723

Closed bjarnef closed 2 years ago

bjarnef commented 3 years ago

Detailed description

Not specific an issue on Our, but on https://community.umbraco.com/learn-about-the-community/karma-leaderboard/ where Community menu item on Our links to https://community.umbraco.com/

Feel free to report this to the right team and close this if there's another place this should be reported 😁

It should probably crop the image first and scale would be ideal too, so it doesn't load an image of 1500 × 1125 px 😅

image

Alternatively it could use the cropped image from Our: https://our.umbraco.com/media/upload/559936fe-4ff0-45f3-857a-115a6bc80f65/_MG_9991.jpg?width=100&height=100&mode=crop&upscale=true

OussamaSALAHOUELHADJ commented 3 years ago

Hey @bjarnef, can you assign this issue to me.

bjarnef commented 3 years ago

@OussamaSALAHOUELHADJ I don't have access to that feature in this repository, but you are welcome to have a look. I guess there is a private repository for the https://community.umbraco.com/ site.

OussamaSALAHOUELHADJ commented 3 years ago

@bjarnef so I just need to fork this repo and work on the issue?

nul800sebastiaan commented 3 years ago

No it's not possible to fix, it's happening in a private repo.

OussamaSALAHOUELHADJ commented 3 years ago

Ok, I see what you mean, just to help you, i think it is a simple bug: the image request must have a query string parameters for the height and the width.

Current request: https://our.umbraco.com/media/upload/{IMAGE_ID}.jpeg

image

Must be: https://our.umbraco.com/media/upload/{IMAGE_ID}.jpg?width=125&height=125&mode=crop&upscale=true

image

nul800sebastiaan commented 3 years ago

Thanks, yep, we're working on it. :)

nul800sebastiaan commented 2 years ago

This has now been fixed, thanks for reporting!

bjarnef commented 2 years ago

@nul800sebastiaan speaking about the community site I noticed the HQ, Admin and C-Trib badges on Our no longer link correct, e.g. from Warren here: https://our.umbraco.com/packages/website-utilities/our-umbraco-taghelpers/

The Admin badge links to https://community.umbraco.com/umbracians-in-action/badges/#admin The HQ badge links to https://community.umbraco.com/umbracians-in-action/badges/#hq The C-Trib badge links to https://community.umbraco.com/umbracians-in-action/badges/#c-trib

The pages was probably moved. Btw. a nicer 404 would be great 😁