umbraco / OurUmbraco

MIT License
96 stars 171 forks source link

Selected version not always highlighted #728

Closed bjarnef closed 2 years ago

bjarnef commented 2 years ago

It seems the current or selected version is not always highlighted.

For example compare these two pages:

https://our.umbraco.com/documentation/Reference/Templating/Modelsbuilder/

image

https://our.umbraco.com/Documentation/Reference/Templating/Modelsbuilder/Builder-Modes

image

It seems the "Builder Modes" page doesn't get the selected-version css class and that the current version is wrapped in <a>, but not on "Models Builder" page. Probably because of the condition setting the selected-version css class.

https://github.com/umbraco/OurUmbraco/blob/main/OurUmbraco.Site/Views/Partials/Documentation/DisplayMarkdown.cshtml#L95-L130

umbrabot commented 2 years ago

Hiya @bjarnef,

Just wanted to let you know that we noticed that this issue got a bit stale and might not be relevant any more.

We will close this issue for now but we're happy to open it up again if you think it's still relevant (for example: it's a feature request that's not yet implemented, or it's a bug that's not yet been fixed).

To open it this issue up again, you can write @umbrabot still relevant in a new comment as the first line. It would be super helpful for us if on the next line you could let us know why you think it's still relevant.

For example:

@umbrabot still relevant This bug can still be reproduced in version x.y.z

This will reopen the issue in the next few hours.

Thanks, from your friendly Umbraco GitHub bot :robot: :slightly_smiling_face: