search

umbraco / OurUmbraco

MIT License
96 stars 168 forks source link

Added my blog #832

Closed RachBreeze closed 9 months ago

RachBreeze commented 10 months ago

Hello

I have added the RSS feed for my blog to the list as per https://twitter.com/mattbrailsford/status/1706373877268365801

Many thanks for developing this functionality

H5YR

Rachel

abjerner commented 10 months ago

Hi @RachBreeze

I just had a look at your feed, and the dates are not RFC 822 as required by the RSS specification:

https://validator.w3.org/feed/check.cgi?url=https%3A%2F%2Fwww.rachelbreeze.dev%2Fblogs%2Frss.xml

At best, this causes some ambiguity about the time (as your format doesn't specify whether it's UTC or something else). At worst, various RSS readers may fail to correctly parse the date and thus fail.

From what I can tell, the old RSS implementation on Our Umbraco would actually accept your format, but would consider the time as UTC - although it should probably be parsed as UTC +1 as UK is still observering summer time (right?). So while the dates are not entirely correct, this shouldn't be a big deal.

I don't think the newer implementation on community.umbraco.com is open source, so I can't tell for sure whether this implementation will accept your format. Maybe it will work the same as the old Our implementation - or maybe it will fail to parse your feed. Maybe someone on Our could help shed some light on this?

RachBreeze commented 10 months ago

Thank you, I've fixed the links, I will take a look at the date format tonight

RachBreeze commented 10 months ago

Hi @nul800sebastiaan and @abjerner

I just wanted to say thank you for your feedback. I've resolved those issues on the feed now.

H5YR

abjerner commented 10 months ago

Looks good to me. And W3C is happy as well 👍

image

nul800sebastiaan commented 9 months ago

Thanks @RachBreeze , merging and deploying now!

umbrabot commented 8 months ago

Hi there @RachBreeze!

First of all: A big #H5YR for making an Umbraco related contribution during Hacktoberfest! We are very thankful for the huge amount of PRs submitted, and all the amazing work you've been doing 🥇

Due to the amazing work you and others in the community have been doing, we've had a bit of a hard time keeping up. 😅 While all of the PRs for Hacktoberfest might not have been merged yet, you still qualify for receiving some Umbraco swag, congratulations! 🎉

In the spirit of Hacktoberfest we've prepared some exclusive Umbraco swag for all our contributors - including you!

As an alternative choice this year, you can opt-out of receiving anything and ask us to help improve the planet instead by planting a tree on your behalf. 🌳

Receive your swag or plant a tree! 👈 Please follow this link to fill out and submit the form, before December 15th, 2022, 23:59:00 UTC.

Following this date we'll be sending out all the swag, but please note that it might not reach your doorstep for a few months, so please bear with us and be patient 🙏

📢 We have just published a summary of all the activity throughout this year's Umbraco Hacktoberfest.

The only thing left to say is thank you so much for participating in Hacktoberfest! We really appreciate the help!

Kind regards, The various Umbraco teams.