umbraco / OurUmbraco

MIT License
96 stars 168 forks source link

Missing meetup groups from the Our home page #837

Closed LottePitcher closed 9 months ago

LottePitcher commented 9 months ago

I noticed that the US meetup that happened yesterday was not showing on the Our list of upcoming meetups. A super quick check and yes I can see that their meetup group name is missing from the list that Our uses to check.

To fix this someone needs to edit OurUmbraco.Site/config/MeetupUmbracoGroups.txt

And add any groups that appear on https://www.meetup.com/pro/umbraco/ but are not in that text list.

nul800sebastiaan commented 9 months ago

I was just debugging some errors in other Hangfire jobs and refreshed my memory on how the meetup connection works. The good news is that we already query from all of our Umbraco groups automatically, so the list is updated automatically. The bad news is that someone created an event without a venue and null reference errors started happening, which was the cause of the list not updating.

Thanks for reporting and too bad nobody gets to do a relatively easy PR 😅

nul800sebastiaan commented 9 months ago

Oh no, I read the code again and I was definitely wrong! It would be GREAT to update this list automatically, but it turns out it isn't updated like that (yet). So this issue is still very much open and ready to work on, sorry for closing prematurely!

rickdoesburg commented 9 months ago

I've added the missing ones :)

nul800sebastiaan commented 9 months ago

Fixed in https://github.com/umbraco/OurUmbraco/pull/838