Add contributors to package

bjarnef commented 4 years ago

This PR fixes https://github.com/umbraco/UmbPack/issues/29

This input would be a comma separated string which should generate the following xml in package.xml

<contributors>
    <contributor>Bjarne Fyrstenborg</contributor>
    <contributor>Jesper Mayntzhusen</contributor>
</contributors>

However I think I am missing something the get this "question" when executing umbpack init command locally?

KevinJump commented 4 years ago

Hi, yeah you need to add a line to the Init Command to get the question asked when running without command options https://github.com/umbraco/UmbPack/blob/dev/src/Verbs/InitCommand.cs#L42

bjarnef commented 4 years ago

Yeah, that's what I added in https://github.com/umbraco/UmbPack/pull/33/commits/0e1d85e6901ce4665be6fc623d3ace4b440051b1

However when running umbpack init locally I don't get asked about the contributors?

jmayntzhusen commented 4 years ago

Could it be that when you run it locally it is not from the source but rather the installed dotnet tool which may not be updated? 🙂

bjarnef commented 4 years ago

Yes, it probably run the installed dotnet tool instead of the local changes. Can I run umbpack locally using the local source instead?

jmayntzhusen commented 4 years ago

Yep, so if you build it will add a file locally, you can see in the readme how to install from that file: https://github.com/umbraco/UmbPack#installing-the-tool

bjarnef commented 4 years ago

It seems I get this error after executing dotnet tool install --global --add-source ./nupkg UmbPack

after uninstalling the global tool it seems it could execute successfully

However I still get the same result when executing umbpack init

jmayntzhusen commented 4 years ago

Hmm strange.. Will take a look as soon as we can 🙂

jmayntzhusen commented 4 years ago

Sorry it has taken this long @bjarnef 🙂

When I run your PR locally I get this:

So not sure what went wrong for you, but my local testing is fine 🙂

jmayntzhusen commented 4 years ago

Thanks a lot for your first contribution to UmbPack! 🎉

This will be part of release 0.9.5 🙂

bjarnef commented 4 years ago

@jmayntzhusen okay thanks! I will have another try 😁 Btw. if your drag & drop or select the package zip to package installer in Umbraco backoffice, you should be able to see these contributors as well in the summary before clicking "install" 😃 🎉

umbraco / UmbPack

Add contributors to package #33