search

umbraco / UmbPack

13 stars 13 forks source link

Archive flag not archiving packages #40

Closed mattbrailsford closed 4 years ago

mattbrailsford commented 4 years ago

I have a build script running on AzurePipelines which is successfully pushing packages to our, but as part of that deploy I have an archive flag set to archive any previous versions of the package, however it doesn't look to be working as the old packages remain un-archived on our.

For example, with this command that was run on my build server

umbpack push D:\a\1\BuildArtifacts\packages\Vendr.PaymentProviders.Opayo.1.0.0.zip -k %OUR_UMBRACO_API_KEY% -w v860,v850,v840,v830,v820 -c false -a Vendr.PaymentProviders.Opayo.*.zip

The existing package Vendr.PaymentProviders.Opayo.0.1.0.zip should have been archived, and indeed the build script logged that this occurred

Archived 1 packages matching the archive pattern.
Extracting info from package.xml file
Name: Vendr.PaymentProviders.Opayo
Version: 1.0.0

Uploading Vendr.PaymentProviders.Opayo.1.0.0.zip to our.umbraco.com ...
The package 'Vendr.PaymentProviders.Opayo.1.0.0.zip' was successfully uploaded to our.umbraco.com

However when I go to Our and check the list of packages, I can still see that 0.1.0 is unarchived

image

Given that the build script is logging the fact that a package is being archived, I'm assuming the UmbPack tool is correctly locating the package and making the request, but it appears something on the Our end is not actually archiving the file.

mattbrailsford commented 4 years ago

So looks like this was a regression issue with the Our site. For some reason this PR https://github.com/umbraco/OurUmbraco/pull/597 got reverted and so the archive endpoint wasn't deployed.

@nul800sebastiaan has re-merged that PR and deployed it and now it is working again.