search

umbraco / UmbPack

13 stars 13 forks source link

Dots not preserved in naming of generated zip-file #41

Closed bjarnef closed 4 years ago

bjarnef commented 4 years ago

It seems the specified name from package.xml isn't preserved when building the package. E.g. Our.Umbraco.ColorPickr seems to generate Our_Umbraco_ColorPickr_1.0.0.zip and replacing . with _.

umbpack pack .\package.xml

while building NuGet package does keep the dot in the naming:

nuget pack .\package.nuspec

image

In v0.9.5 we can overide the name, but it would also require to add the version manually.

umbpack pack .\package.xml -n Our.Umbraco.ColorPickr_1.0.0.zip
bjarnef commented 4 years ago

Not sure if something like this is possible to specify a format of to filename?

umbpack pack .\package.xml -n {name}_{version}.zip
Rockerby commented 4 years ago

Thanks Bjarne and Kevin. This fix has been merged and pushed as part of v1.0.0.