search

umbraco / UmbPack

13 stars 13 forks source link

WorksWith default value hardcoded? #42

Open leekelleher opened 4 years ago

leekelleher commented 4 years ago

Does the default value for the WorksWith option need to be manually updated when a new Umbraco minor version is released?

https://github.com/umbraco/UmbPack/blob/dev/src/Verbs/PushCommand.cs#L41

At the time of writing, v8.6.4 is the current version, and default value for WorksWith is "v850".

jmayntzhusen commented 4 years ago

Ideally we'd let a blank, default just not pass the value along to Our at all, and then be able to find the "current" version once it's sent to Our and set it as that 🤔

Would require some work on both Our and UmbPack though, which is also why it wasn't done for an initial release.

I can tell you that this is the receiving controller on Our for anyone who wants to have a play with it: https://github.com/umbraco/OurUmbraco/blob/main/OurUmbraco/Project/Api/ProjectUploadController.cs#L78

umbrabot commented 4 years ago

Hi @leekelleher,

We're writing to let you know that we would love some help with this issue. We feel that this issue is ideal to flag for a community member to work on it. Once flagged here, folk looking for issues to work on will know to look at yours. Of course, please feel free work on this yourself ;-). If there are any changes to this status, we'll be sure to let you know.

For more information about issues and states, have a look at this blog post

Thanks muchly, from your friendly Umbraco GitHub bot :-)