umbraco / UmbPack

13 stars 13 forks source link

Allow the same structure of 'files' section from the existing package.xml #43

Open Rockerby opened 4 years ago

Rockerby commented 4 years ago

It would be nice if the files section in the packages.xml (to be fed into UmbPack) accepted the same format as the output packages.xml. A potential use case for this might be if someone has an existing package they want to use the tool with, without rewriting the files section.

Currently the format of the tool requires the files section to be the following:

<folder path="src/xxx/App_Plugins/duug" orgPath="App_Plugins/duug" />
<file path="src/xxx/bin/release/xxx.dll" orgPath="bin/xxx.dll" />

The Umbraco package.xml uses the below format:

<file>
  <guid>package.manifest</guid>
  <orgPath>src/duug/App_Plugins/duug</orgPath>
  <orgName>package.manifest</orgName>
</file>
jmayntzhusen commented 4 years ago

Oh I was sure it supported both!

Think the relevant area is this one, no time to test it right now though: https://github.com/umbraco/UmbPack/blob/dev/src/Verbs/PackCommand.cs#L221

I'll tag this as up for grabs 🙂

KevinJump commented 4 years ago

I think the problem is we would still need a source, so the existing format tells umbraco where to put the file, but we add the path attribute to our setup so we can tell UmbPack where to get the file from.

we could make it so it checks for orgPath as an element if it is missing as an attribute, but we still need to get path :(

maybe we should have a basePath setting on the files node - then everything could be relative from that? or maybe set relative path to package.xml as in issue #25

umbrabot commented 3 years ago

Hi @Rockerby,

We're writing to let you know that we would love some help with this issue. We feel that this issue is ideal to flag for a community member to work on it. Once flagged here, folk looking for issues to work on will know to look at yours. Of course, please feel free work on this yourself ;-). If there are any changes to this status, we'll be sure to let you know.

For more information about issues and states, have a look at this blog post

Thanks muchly, from your friendly Umbraco GitHub bot :-)