umbraco / Umbraco-CMS.Accessibility.Issues

6 stars 1 forks source link

Search modal - Missing modal trap #18

Closed umbrabot closed 2 years ago

umbrabot commented 2 years ago

Steps to replicate:

  1. Open search modal in the top navigation (top right)
  2. Modal will appear (modal is missing modal trap)

Issue: Modal dialogs: Users must not be able to Tab away from a modal dialog without explicitly dismissing it

Why it matters: The purpose of a modal dialog is to constrain user input (temporarily) to controls within the dialog. Just as mouse users should not be able to click elements outside the dialog, keyboard users should not be able to Tab to elements outside the dialog.

How to fix:

W3 reference: https://www.w3.org/WAI/WCAG21/Understanding/focus-order.html

mikecp commented 2 years ago

Setting to Done after merge of PR #12786

nul800sebastiaan commented 2 years ago

Fixed in https://github.com/umbraco/Umbraco-CMS/pull/12786