umbraco / Umbraco-CMS.Accessibility.Issues

6 stars 1 forks source link

Packages - Modal - Empty buttons #57

Open umbrabot opened 2 years ago

umbrabot commented 2 years ago

Open package (Umbraco forms) - Print screens are reporting as Empty buttons

Steps to replicate:

  1. Navigate to packages section
  2. Open a package (e.g. Umbraco forms)
  3. View the print modals (near the bottom of the page)
  4. Each are empty buttons

Issue: Empty button: A button is empty or has no value text

Why it matters: When navigating to a button, descriptive text must be presented to screen reader users to indicate the function of the button.

How to fix: Place text content within the

BatJan commented 1 year ago

PR for this one here https://github.com/umbraco/Umbraco-CMS/pull/13114 - Changed the button back to an anchor tag with a valid ng-src attribute pointing at the larger image as one would usually do implementing lightboxes on regular websites.