umbraco / Umbraco-CMS

Umbraco is a free and open source .NET content management system helping you deliver delightful digital experiences.
https://umbraco.com
MIT License
4.42k stars 2.67k forks source link

Generating ModelsBuilder models fails if using tags property editor #11666

Closed bjarnef closed 2 years ago

bjarnef commented 2 years ago

Which exact Umbraco version are you using? For example: 9.0.1 - don't just write v9

9.0.1

Bug summary

When I create a datatype instance using Tags property editor and JSON (default) as storage type and afterwards generate ModelsBuilder models these fails to be generated and the application is shutting down.

image

E.g. when used on a News Article document type.

However when I change storage type to CSV there are no issues.

image

Specifics

No response

Steps to reproduce

Expected result / actual result

I would expect to be able to use Tags JSON storage type without generating ModelsBuilder models fail.

I have the following ModelsBuilder configuration:

"ModelsBuilder": {
    "ModelsDirectory": "~/../MyProject.Core/Models/",
    "ModelsMode": "SourceCodeManual",
    "AcceptUnsafeModelsDirectory": true,
    "Enable": true
}

I suspect it may be related to other JSON errors I am seeing in Umbraco v9.0.1, but could maybe be related to Forms or Deploy?

https://github.com/umbraco/Umbraco-CMS/issues/11647

bjarnef commented 2 years ago

I think it is mainly an issue when using dotnet watch run as it seems there are no issues when using dotnet run

umbrabot commented 2 years ago

Hiya @bjarnef,

Just wanted to let you know that we noticed that this issue got a bit stale and might not be relevant any more.

We will close this issue for now but we're happy to open it up again if you think it's still relevant (for example: it's a feature request that's not yet implemented, or it's a bug that's not yet been fixed).

To open it this issue up again, you can write @umbrabot still relevant in a new comment as the first line. It would be super helpful for us if on the next line you could let us know why you think it's still relevant.

For example:

@umbrabot still relevant This bug can still be reproduced in version x.y.z

This will reopen the issue in the next few hours.

Thanks, from your friendly Umbraco GitHub bot :robot: :slightly_smiling_face: