search

umbraco / Umbraco-CMS

Umbraco is a free and open source .NET content management system helping you deliver delightful digital experiences.
https://umbraco.com
MIT License
4.49k stars 2.69k forks source link

Aligning embedded video in RTE #11837

Open BrionyMcKenz opened 2 years ago

BrionyMcKenz commented 2 years ago

Which exact Umbraco version are you using? For example: 9.0.1 - don't just write v9

8.17.1

Bug summary

Content editors cannot align embedded videos in the RTE.

Specifics

Embedding a video in the RTE wraps it in a div with the "mceNonEditable" class. This means users can't center-align the video. I can see in the umbraco.services.js file there's a comment just above where this is done saying: // Wrap HTML preview content here in a DIV with non-editable class of .mceNonEditable // This turns it into a selectable/cutable block to move about

Steps to reproduce

Expected result / actual result

I expect to be able to use the "Align center" button to center the video in the RTE. Because the "mceNonEditable" class has been added, I am not able to center the video.

bergmania commented 1 year ago

Hi @BrionyMcKenz.

Sorry for the late reply.

I can confirm this is a problem in Umbraco 8 to 10. It has been fixed in Umbraco 11 with the upgrade of TinyMCE to version 6.

I'll set it up for grabs to fix in the older versions.

github-actions[bot] commented 1 year ago

Hi @BrionyMcKenz,

We're writing to let you know that we would love some help with this issue. We feel that this issue is ideal to flag for a community member to work on it. Once flagged here, folk looking for issues to work on will know to look at yours. Of course, please feel free work on this yourself ;-). If there are any changes to this status, we'll be sure to let you know.

For more information about issues and states, have a look at this blog post.

Thanks muchly, from your friendly Umbraco GitHub bot :-)

brionymckenzie commented 1 year ago

I've tested this in Umbraco 11 and it seems like it only works when you first add the video. If you come back to the page after saving, it is no longer possible to align the video :(

brionymckenzie commented 1 year ago

Is there any update on this issue? I'm surprised other people haven't reported it. It's not ideal that you can only set formats when you first add the video so it's definitely relevant to v11.