search

umbraco / Umbraco-CMS

Umbraco is a free and open source .NET content management system helping you deliver delightful digital experiences.
https://umbraco.com
MIT License
4.47k stars 2.69k forks source link

Root node gets visiting url on other domains. #12625

Open Sophiehillebrant opened 2 years ago

Sophiehillebrant commented 2 years ago

Which exact Umbraco version are you using? For example: 9.0.1 - don't just write v9

9.5.0

Bug summary

When site contains multiple domains, one domain is reachable from another domain Example: Umbraco site is set up with two root nodes, DomainX.com and DomainY.com. Then try to reach the second root node with domain name DomainY from DomainX.com/DomainY. This should not be possible, but it is. This is problematic from an SEO standpoint.

The child nodes under DomainY are not reachable from DomainX, only the root node.

Have been in contact with Umbraco support concerning this issue and they confirmed this is a bug in V9.

Specifics

No error messages are shown, this is just a case of being able to reach a domain root node where it should not be possible.

Steps to reproduce

  1. Install an Umbraco project with standard MVC setup, plus some document types.
  2. Create at least two root nodes with child nodes underneath them.
  3. Give the root nodes different hostnames/domain names.
  4. Browse the first domain as a visitor and then try to use the second domain name as slug.

Expected result / actual result

Not being able to reach another domain root node from one domain.

jesperlange commented 2 years ago

I have been able to reproduce this on my own setup.

image

Images and links to further describe the issue:

https://www.sunshineandunicorns.gq/ And with the 2nd root node included in the link https://www.sunshineandunicorns.gq/andre

Where 2nd rootnode should only be https://nomore.sunshineandunicorns.gq/

kjac commented 1 year ago

I can reproduce this as well in V10. I will mark it as up for grabs.

Fixing this is in principle functionally breaking, so whomever picks this up should get in touch via this issue to discuss if we need to consider a different target than Vnext.

github-actions[bot] commented 1 year ago

Hi @Sophiehillebrant,

We're writing to let you know that we would love some help with this issue. We feel that this issue is ideal to flag for a community member to work on it. Once flagged here, folk looking for issues to work on will know to look at yours. Of course, please feel free work on this yourself ;-). If there are any changes to this status, we'll be sure to let you know.

For more information about issues and states, have a look at this blog post.

Thanks muchly, from your friendly Umbraco GitHub bot :-)

viktor-knowit commented 2 months ago

⚠️ This is still an issue in v10.8.6. ⚠️

Simplified explanation:

2 sites with different hostnames:

Site name Site hostname Url name
My first site myfirstsite.com my-first-site
My second site mysecondsite.com my-second-site

Now when I type this URL myfirstsite.com/my-second-site, the second site will load even if the hostname is for the first site.

⚠️ This is not good from an SEO perspective.