umbraco / Umbraco-CMS

Umbraco is a free and open source .NET content management system helping you deliver delightful digital experiences.
https://umbraco.com
MIT License
4.49k stars 2.69k forks source link

Block list not loading images till clicked #13916

Open craigs100 opened 1 year ago

craigs100 commented 1 year ago

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

11.2.0

Bug summary

When a block list contains a MediaPicker3 it only starts to load it's images once the block list item is opened. It can take many seconds to load if left alone. However, if the list item is clicked into, the image will load immediately. Below are two videos, one where the images are left to load themselves and one where the block list items are clicked into asap.

https://user-images.githubusercontent.com/1143883/223108348-cb24abd2-442b-466d-a850-30d3dc0a9e24.mp4

https://user-images.githubusercontent.com/1143883/223108382-038a3819-810f-4e7f-8ec4-98cbc998ac89.mp4

Specifics

No response

Steps to reproduce

Create a block list with an item that contains a MediaPicker3. Add images. Then navigate the block list.

Expected result / actual result

Expected that the images appear immediately, just as they did in the old nested content structure.

Actual result is either a long delay before the image appears or it only appears once the block list item is clicked on

github-actions[bot] commented 1 year ago

Hi there @craigs100!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot :robot: :slightly_smiling_face:

kjac commented 1 year ago

Hi there @craigs100,

Thank you for reporting this 🚀 I can reproduce in V10 too. How absolutely strange. The image is actually loading, but the "loading" state of the media picker only disappears when one clicks inside the block item.

This only happens when using inline editing mode, so the best workaround is to use the default infinite editing mode instead.

image

We'd love some help getting this fixed. I'm putting this up for grabs so you or anyone else can start working on it.

github-actions[bot] commented 1 year ago

Hi @craigs100,

We're writing to let you know that we would love some help with this issue. We feel that this issue is ideal to flag for a community member to work on it. Once flagged here, folk looking for issues to work on will know to look at yours. Of course, please feel free work on this yourself ;-). If there are any changes to this status, we'll be sure to let you know.

For more information about issues and states, have a look at this blog post.

Thanks muchly, from your friendly Umbraco GitHub bot :-)

skttl commented 1 year ago

https://discordapp.com/channels/869656431308189746/1085146280692563979/1085157124440608788

digbyswift-joe commented 1 year ago

Quick note to say we were also experiencing this issue, and had been working to replicate.

Originally we flagged the issue on this (now closed) ticket: https://github.com/umbraco/Umbraco-CMS/issues/13822

We now have a reproducible example that also points to inline editing mode being the issue, and this is in Umbraco 11.2.2.

kasparboelkjeldsen commented 1 year ago

Have possible solution for this, pull request inc.