Block Editor Disabled if Block has Vary By Culture

alandraper commented 1 year ago

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

11.2.2

Bug summary

The block editor elements (e.g. RTE) appear disabled if the block element has "Vary by Culture" set.

The editor element seems to have "preview" set which causes everything to be disabled.

Specifics

Steps to reproduce

Create new Umbraco site from 11.2.2 template
Create new Document Type "Page"; Allow at root
Add property "Demo Grid" with "Block Grid" editor
Install the demo "Umbraco Block Grid Demo" block grid
Verify everything works correctly a. Go to Content; b. Create new Page at root; c. Under "Demo Grid", add new "Rich Text" block. d. Should appear correctly e. Discard changes
Go back to settings and add new Language
Go to Document Types / Umbraco Block Grid Demo / Rich Text
Go to Permissions, and turn "Allow vary by culture" on
Save changes
Repeat process in (6) above, but notice that the editor is grayed out.

Expected result / actual result

Do not expect that allowing Vary by Culture would disable an editor control.

github-actions[bot] commented 1 year ago

Hi there @alandraper!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
We'll replicate the issue to ensure that the problem is as described.
We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot :robot: :slightly_smiling_face:

alandraper commented 1 year ago

I think the problem happens only if the Property "Demo Grid" does not have Vary by Culture set, but the Block element does have it set.

kjac commented 1 year ago

Hi @alandraper,

Thank you for reporting this 👍 I can reproduce on V11 latest.

As you correctly point out, the problem only occurs if the element type is configured as culture variant and the container property (block editor) is not.

This applies to both Block Grid and Block List.

The obvious workaround is to not make element types vary by culture. In most scenarios this is also the preferable configuration, and it is also the default.

Still, the UI should not allow configuring something that yields a non-functional editing experience. I'll mark this as up for grabs if anyone would like to work on it.

github-actions[bot] commented 1 year ago

Hi @alandraper,

We're writing to let you know that we would love some help with this issue. We feel that this issue is ideal to flag for a community member to work on it. Once flagged here, folk looking for issues to work on will know to look at yours. Of course, please feel free work on this yourself ;-). If there are any changes to this status, we'll be sure to let you know.

For more information about issues and states, have a look at this blog post.

Thanks muchly, from your friendly Umbraco GitHub bot :-)

cf-marc commented 1 year ago

Hi @kjac

It seems this doesn't work in Version 10.5.0 too. Thanks for fixing it.

Best regards

JBoye commented 1 year ago

As you correctly point out, the problem only occurs if the element type is configured as culture variant and the container property (block editor) is not.

Is there a reason why this shouldn't be possible?

I think it's a perfectly valid use-case to have the overall page structure fixed and the elements varying be culture.

kjac commented 1 year ago

@JBoye it's a perfectly valid use-case. We really want this feature, and it's already on the roadmap under Next ... it's called "Block Level Variations for Umbraco CMS" 😄

mertglcan commented 10 months ago

This issue still valid at v12.2 .But its fine with BlokGrid, but not working with Block List.

peaxe commented 4 weeks ago

Got the same error in Umbraco 13.4.1 (for Block List). The presented fix of not allowing "Allow vary by culture" for the element type fixed the issue.

umbraco / Umbraco-CMS