No validation message when decimals are added to a Numeric property

[FransdeJong]

Which Umbraco version are you using?

10.4.2 10.5.0 11.3.0

Bug summary

A numeric property editor won't save decimals in 10.4.2, 10.5.0 and 11.3.0.

Specifics

Tested on a clean install of 10.4.2, 10.5.0 and 11.3.0

Steps to reproduce

1. Install 10.4.2, 10.5.0 or 11.3.0
2. Add a doctype and allow at root
3. Add a property, select numeric and set step to 0.01
4. Add content and try and save 1 in the property (this works)
5. Now save the same property with 1.01 (this fails)

Expected result / actual result

I expected it to save a decimal, it doesn't save it instead.

[github-actions[bot]]

Hi there @FransdeJong!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

• We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
• If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
• We'll replicate the issue to ensure that the problem is as described.
• We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot :robot: :slightly_smiling_face:

[ronaldbarendse]

The default Numeric data type uses Umbraco.Integer as property editor, so only whole numbers are allowed. But even with that in mind, there's a few issues I can quickly spot:

• The configuration values (min, step size and max) should only allow whole numbers for the Umbraco.Integer property editor;
• There's no validation error shown when the entered value isn't correct;
• Changing the property editor on the existing Numeric data type doesn't seem to clear the caches and requires a restart to start accepting the decimal values 🤯

[FransdeJong]

Arnold just pointed me at the integer part. I totally overlooked it since I remember only one numeric being present in V8? Also the lack of feedback didn't point me in the right direction.

[elit0451]

Yes, providing some sort of validation message would be very useful in this case. Everything that @ronaldbarendse pointed out is a good candidate for an up-for-grabs fix.

[github-actions[bot]]

Hi @FransdeJong,

We're writing to let you know that we would love some help with this issue. We feel that this issue is ideal to flag for a community member to work on it. Once flagged here, folk looking for issues to work on will know to look at yours. Of course, please feel free work on this yourself ;-). If there are any changes to this status, we'll be sure to let you know.

For more information about issues and states, have a look at this blog post.

Thanks muchly, from your friendly Umbraco GitHub bot :-)