Multi Node Tree Picker not allowing selection

ccasalicchio commented 1 year ago

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

11.4.0

Bug summary

Multi Node Tree Picker is not working, after selections, clicking submit shows an error on the console

It's trying to split the property value, when it should be splitting the content data

Specifics

angular.js:15697 TypeError: $scope.model.value.split is not a function
    at $scope.add (umbraco.controllers.min.js?d=622eef5fd13567437e5b670d48f0a57e622aa980:1:108431)
    at umbraco.controllers.min.js?d=622eef5fd13567437e5b670d48f0a57e622aa980:1:107333
    at Function.mr (underscore-min.js?d=622eef5fd13567437e5b670d48f0a57e622aa980:6:9283)
    at $scope.currentPicker.submit (umbraco.controllers.min.js?d=622eef5fd13567437e5b670d48f0a57e622aa980:1:107288)
    at Object.submit (umbraco.controllers.min.js?d=622eef5fd13567437e5b670d48f0a57e622aa980:1:254201)
    at fn (eval at compile (angular.js:16548:15), <anonymous>:4:232)
    at d.<computed> [as action] (angular.js:11517:22)
    at UmbButtonController.clickButton (umbraco.directives.min.js?d=622eef5fd13567437e5b670d48f0a57e622aa980:1:67547)
    at fn (eval at compile (angular.js:16548:15), <anonymous>:4:245)
    at e (angular.js:29123:13)

Steps to reproduce

use a multi node tree picker and select any node

Expected result / actual result

No response

github-actions[bot] commented 1 year ago

Hi there @ccasalicchio!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
We'll replicate the issue to ensure that the problem is as described.
We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot :robot: :slightly_smiling_face:

ccasalicchio commented 1 year ago

I want to submit a fix, are there any instructions on how to update, compile, test, and submit PRs?

georgebid commented 1 year ago

I want to submit a fix, are there any instructions on how to update, compile, test, and submit PRs?

Hey @ccasalicchio! It's great to hear you're keen to put in a fix for this one, you can find our contribution instructions here, which should answer all of your questions! https://github.com/umbraco/Umbraco-CMS/blob/contrib/.github/CONTRIBUTING.md

Let me know if you need anything clarifying 😄

ccasalicchio commented 1 year ago

thank you :) @georgebid

ccasalicchio commented 1 year ago

The issue is with 11.4.0, how do I collaborate on that one? I just followed the instructions from https://github.com/umbraco/Umbraco-CMS/blob/contrib/.github/CONTRIBUTING.md but it came with version 12 RC :( @georgebid

ccasalicchio commented 1 year ago

anyone can clarify please? @georgebid

georgebid commented 1 year ago

sorry for the delay @ccasalicchio - have you tried to replicate your issue on the version 12 branch yet? Or is it very specific to 11.4.0? If the issue persists when you check on the version 12 branch, you can fix it here. All contributions go to the /contrib branch and we'll cherry-pick things that make sense to other versions 😄

ccasalicchio commented 1 year ago

Hey @georgebid , v12 doesn't have the issue, only 11.4.0. Is there a way to submit a fix for 11.4.0? in 12-rc some code, no error.

nul800sebastiaan commented 1 year ago

@ccasalicchio I think you'll find that the code between the v11/dev (left in the image) branch and the contrib (right in the image) branch is the same.

So I don't think this is just a problem on v11, but more a problem with something in your current solution. If you can reproduce this problem on a clean install of v11.4 then please detail the steps so we can have a look. My MNTP works fine in a 11.4 website.

https://github.com/umbraco/Umbraco-CMS/assets/304656/735cf85d-0abe-46fc-9f1b-05b0c266d13b

ccasalicchio commented 1 year ago

You are totally right, I feel dumb! It was bad data from the previous property editor, messing up the MultiNode TreePicker. After deleting the bad data, the editor worked just fine :-(

umbraco / Umbraco-CMS