Tour not coded according to best practice

plannero commented 1 year ago

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

10.4.0

Bug summary

A modal dialog appears after login until the user has clicked “Don’t show this tour again”. Looks nice and friendly, but for a screen reader user to even find this information he or she must navigate to the very end of the page.

Specifics

According to best practice for modal dialogs, they should capture the full focus of the user until dismissed. Users shouldn’t even be able to tab to or read the content behind the modal until it has been closed, and of course the modal – just as all other groups of content, should have a label. Please see (and implement) https://www.w3.org/WAI/ARIA/apg/patterns/dialog-modal/

Steps to reproduce

Log in to Umbraco 10.4.0 for the first time. If the "Tour invite" appears, try to find it with a screen reader. Try also to navigate to and from it with the keyboard.

Expected result / actual result

See specifics, above.

github-actions[bot] commented 1 year ago

Hi there @plannero!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
We'll replicate the issue to ensure that the problem is as described.
We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot :robot: :slightly_smiling_face:

andr317c commented 1 year ago

Hey!

Thanks for taking the time to raise this issue! This is something we would like help with, I'll set this issue as up for grabs 😄

github-actions[bot] commented 1 year ago

Hi @plannero,

We're writing to let you know that we would love some help with this issue. We feel that this issue is ideal to flag for a community member to work on it. Once flagged here, folk looking for issues to work on will know to look at yours. Of course, please feel free work on this yourself ;-). If there are any changes to this status, we'll be sure to let you know.

For more information about issues and states, have a look at this blog post.

Thanks muchly, from your friendly Umbraco GitHub bot :-)

nagolucky18 commented 10 months ago

I will take a look at this one.

umbraco / Umbraco-CMS