umbraco / Umbraco-CMS

Umbraco is a free and open source .NET content management system helping you deliver delightful digital experiences.
https://umbraco.com
MIT License
4.49k stars 2.69k forks source link

Image upload on drag-and-drop is processed before choosing what image type #14876

Open SOTFB opened 1 year ago

SOTFB commented 1 year ago

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

10.7

Bug summary

We have three different themes for our site's, so for reasons they have slightly different image croppings etc. Hence we have three different custom Media Types for images. (We are not using the default image media type.) When drag-and-drop:ing an image onto the drop zone, a modal show where you are supposed to choose what type the dropped file should be. However Umbraco processes it as a default media type before you can choose, and you also see the file being added to the directory behind the modal. Once you choose image type the modal just closes and "nothing more happens".

Specifics

URL: /umbraco#/media

As well as if you edit content and would like to insert an image to the page (picking) the right hand sidebar show up and the exact same phenomenon happens there too.

Steps to reproduce

Add another image meda type and follow the flow described in Bug summary. It was confirmed at support.umbraco.com in ticket 84026.

Expected result / actual result

Umbraco should wait in the modal for user's choice for what type the dropped file should be. Then process the image and close the modal automatically. Reasonably then highlight the uploaded file so that one can edit crops, ALT text etc.

github-actions[bot] commented 1 year ago

Hi there @SOHTFB!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot :robot: :slightly_smiling_face:

kjac commented 1 year ago

Hi @SOHTFB,

Thank you for reporting 😄

I can reproduce this in V10. It does not happen in V11 or V12, so something must have been fixed along the way:

14876.webm

I have tried to tie this fix to a PR, but I haven't found any that makes any sense, so I can't entirely put my finger on when this was fixed.

I'm going to put this up for grabs, in case you or anyone else would like to have a go a fixing it.

github-actions[bot] commented 1 year ago

Hi @SOHTFB,

We're writing to let you know that we would love some help with this issue. We feel that this issue is ideal to flag for a community member to work on it. Once flagged here, folk looking for issues to work on will know to look at yours. Of course, please feel free work on this yourself ;-). If there are any changes to this status, we'll be sure to let you know.

For more information about issues and states, have a look at this blog post.

Thanks muchly, from your friendly Umbraco GitHub bot :-)

rammi987 commented 1 year ago

hello @kjac I have the same issue in Umbraco 10.3 and it got fixed in version 10. see this issue https://github.com/umbraco/Umbraco-CMS/issues/13210