Clicking "Stay" if there are Unsaved Changes Results in Misleading / Confusing GUI Changes

[nagolucky18]

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

12.3.0-rc

Bug summary

Clicking "Stay" on "You have unsaved changes" dialogs results in the top bar and side bar updating but not the center of the page.

Specifics

Clicking "Stay" on the "You have unsaved changes" dialog results in the top bar and side bar updating but not the center of the page. Because of this, it is difficult to tell what happened after the dialog was clicked. Only by observing the URL can it be seen that the page didn't actually change, only the GUI.

Steps to reproduce

1. Under "Settings", edit an existing document type.
2. Take note of the URL.
3. Click "Content".
4. Notice that the "You have unsaved changes" dialog appears.
5. Notice that "Content" is now highlighted in the top bar.
6. Notice that "Content" now shows in the left sidebar.
7. Notice that the center of the page still contains the information from "Settings".
8. Click "Stay".
9. Notice that the top bar and leftside bar do not revert and now show incorrect information about what page the user is actually located at.
10. Notice that the URL is still the same URL from 2.

Note: This is just one way to observe this. This can be observed for any scenario where there are unsaved changes and "Stay" is clicked.

Found while reproducing #14934.

Expected result / actual result

No changes to GUI are observed if user chooses to stay on the current page due to unsaved changes.

[github-actions[bot]]

Hi there @nagolucky18!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

• We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
• If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
• We'll replicate the issue to ensure that the problem is as described.
• We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot :robot: :slightly_smiling_face:

[kjac]

Hi @nagolucky18,

Thank you for reaching out 😄

I believe this behavior has been around since forever. It is certainly not optimal, but may be a product of AngularJS limitations.

In any case I'm putting this up for grabs, if someone wants to make an attempt at fixing it.

[github-actions[bot]]

Hi @nagolucky18,

We're writing to let you know that we would love some help with this issue. We feel that this issue is ideal to flag for a community member to work on it. Once flagged here, folk looking for issues to work on will know to look at yours. Of course, please feel free work on this yourself ;-). If there are any changes to this status, we'll be sure to let you know.

For more information about issues and states, have a look at this blog post.

Thanks muchly, from your friendly Umbraco GitHub bot :-)