umbraco / Umbraco-CMS

Umbraco is a free and open source .NET content management system helping you deliver delightful digital experiences.
https://umbraco.com
MIT License
4.49k stars 2.69k forks source link

Backoffice: Required message doesn't show for the mandatory Eye dropper color picker property #15495

Open nick-hoang opened 10 months ago

nick-hoang commented 10 months ago

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

12.2.0

Bug summary

In the Backoffice, required message doesn't show for the mandatory Eye dropper color picker property while creating new content: https://prnt.sc/6ChzxUM3svNW

Specifics

Please check the screen record here: https://www.loom.com/share/427f1ccc13784e85953374e0b0d9eb3c?sid=fd08e426-0306-452b-a67d-2c1d2d921e02

Steps to reproduce

Expected result / actual result

Expected result: The "Background colour" property should show an error message to say "Value cannot be empty"

Actual result: No error message be show

github-actions[bot] commented 10 months ago

Hi there @nick-hoang!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot :robot: :slightly_smiling_face:

andr317c commented 10 months ago

Hey! Thanks for posting this issue. I was able to reproduce this on 12.3.6 and 13.0.2. But I had to set the property as mandatory. If you press save instead of save and publish, it works 😕. I'll go ahead and mark this issue as an up for grabs

github-actions[bot] commented 10 months ago

Hi @nick-hoang,

We're writing to let you know that we would love some help with this issue. We feel that this issue is ideal to flag for a community member to work on it. Once flagged here, folk looking for issues to work on will know to look at yours. Of course, please feel free work on this yourself ;-). If there are any changes to this status, we'll be sure to let you know.

For more information about issues and states, have a look at this blog post.

Thanks muchly, from your friendly Umbraco GitHub bot :-)

AdamPrendergast commented 9 months ago

@nick-hoang @andr317c

I'm unable to replicate in the latest build (version 13.2.0-rc.preview.17). Potentially fixed by another ticket?

@nick-hoang could you re-upload the video if it's not too much trouble. The original link seems to be dead.

Replication steps on latest.

Create new 'Eye Dropper Color Picker'

image

Set 'Field is mandatory' to on/true and add a error message.

image

When I 'Save and Publish' content item with no picked colour. Then it displays the error message entered above:

image

When I 'Save' content item with no picked colour. Then it displays the error message entered above:

image

nick-hoang commented 8 months ago

hi @AdamPrendergast

Here's my testing on latest Umbraco 13 and the issue is still happening: https://www.loom.com/share/479542ccad4c412f93e066d9f2e3925c?sid=33cb0e3f-5a07-408f-9ecf-1af6602b35af

The issue only happens on the first save and publish.

Hope it help.

Cheers, Nick