umbraco / Umbraco-CMS

Umbraco is a free and open source .NET content management system helping you deliver delightful digital experiences.
https://umbraco.com
MIT License
4.45k stars 2.68k forks source link

Can't sort children with custom granular permission #15608

Open KristofferEriksen opened 9 months ago

KristofferEriksen commented 9 months ago

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

10.8.3

Bug summary

We have created a solution to a client, where we have a lot of custom granular permissions. The permissions is set codewise and reflected in Umbraco on the specific roles. The solution is a multisite solution with a lot of unique websites in the root. In the root we also have two shared folders and the recyclebin We have created a wizard for the client to be able to create subsites by a, of them, developed form-application, that interacts with a webservice we have created for them. We're using Umbraco standard functionality/code, for creating the content. When a new site is created, we create two new Umbraco Roles, and set specific granular permissions for each role, so they only have access for the new site in content-tree and media-tree. The Media-root is set to the newly created folder, and the Content-root is set to root, where when then limits the viewability and accessability to the new site, the two shared folders and the recyclebin. I can reproduce the same error in my local development-environment, and tried different setups, but either the roles have access to the entire content-tree (and option of sorting) or they just have the correct access for the new site (without the ability to sort).

Specifics

I've checked in Firefox and Chrome, but the issue is related to Umbraco, and not browserspecific.

Steps to reproduce

A video of the error can be seen at the Umbraco Support issue: https://support.umbraco.com/attachments/token/mv65GEidk5Sc2xGN0tT70MH9I/?name=Umbraco+-+gentofte10.local+%E2%80%94+Mozilla+Firefox+2024-01-16+15-18-20_min.mp4

Support Issue: https://support.umbraco.com/hc/requests/86366

Expected result / actual result

I would expect that when setting granular permissions on a node, it reflects on that specific node and children.

github-actions[bot] commented 9 months ago

Hi there @KristofferEriksen!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot :robot: :slightly_smiling_face:

elit0451 commented 8 months ago

Hi @KristofferEriksen 👋

Thanks for reaching out! I can reproduce this - it seems like the bug is related to the browse permission - the sort behaviour changes when Browse is disabled on the default permissions. I will mark it as up for grabs as we would like some help with this 🙂

https://github.com/umbraco/Umbraco-CMS/assets/21998037/32279f11-4383-45ae-bdd2-3a44073a3d87


I am modifying the permissions of a user group (on the left) that the user, that I am logged in with (on the right), is part of.

github-actions[bot] commented 8 months ago

Hi @KristofferEriksen,

We're writing to let you know that we would love some help with this issue. We feel that this issue is ideal to flag for a community member to work on it. Once flagged here, folk looking for issues to work on will know to look at yours. Of course, please feel free work on this yourself ;-). If there are any changes to this status, we'll be sure to let you know.

For more information about issues and states, have a look at this blog post.

Thanks muchly, from your friendly Umbraco GitHub bot :-)

AdamPrendergast commented 8 months ago

Hi @elit0451 I'm happy to take a look at this if no one else has already.

AdamPrendergast commented 8 months ago

I've also managed to replicate this locally.

I'll have a look through over the weekend and see what I can find :)

AdamPrendergast commented 8 months ago

@elit0451 Created a draft PR with a potential idea for resolving this

https://github.com/umbraco/Umbraco-CMS/pull/15677

elit0451 commented 8 months ago

Great, thanks for looking into it! 🙌